linux-kernel - Re: [PATCH] ASoC: rcar: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Nov 2015 06:25:36 +0000
From:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	Mark Brown <broonie@...nel.org>, <alsa-devel@...a-project.org>,
	Mengdong Lin <mengdong.lin@...ux.intel.com>,
	<linux-sh@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH] ASoC: rcar: remove unused variable


Hi Arnd, Mark

> After a recent cleanup, the soc_card variable became unused
> and now produces a warning:
> 
> soc/sh/rcar/core.c: In function '__rsnd_kctrl_new':
> soc/sh/rcar/core.c:801:23: warning: unused variable 'soc_card' [-Wunused-variable]
> 
> This removes the variable.
> 
> Fixes: 1a497983a5ae ("ASoC: Change the PCM runtime array to a list")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c
> index c6685f14b9cb..90b244c1f526 100644
> --- a/sound/soc/sh/rcar/core.c
> +++ b/sound/soc/sh/rcar/core.c
> @@ -798,7 +798,6 @@ static int __rsnd_kctrl_new(struct rsnd_mod *mod,
>  			    void (*update)(struct rsnd_dai_stream *io,
>  					   struct rsnd_mod *mod))
>  {
> -	struct snd_soc_card *soc_card = rtd->card;
>  	struct snd_card *card = rtd->card->snd_card;
>  	struct snd_kcontrol *kctrl;
>  	struct snd_kcontrol_new knew = {

It seems this patch was accepted to topic/rcar branch,
but I got compile error

/opt/home/morimoto/WORK/linux/sound/soc/sh/rcar/core.c: In function '__rsnd_kctrl_new':
/opt/home/morimoto/WORK/linux/sound/soc/sh/rcar/core.c:807:18: error: 'soc_card' undeclared (first use in this function)
   .index  = rtd - soc_card->rtd,
                  ^
/opt/home/morimoto/WORK/linux/sound/soc/sh/rcar/core.c:807:18: note: each undeclared identifier is reported only once for each function it appears in
make[6]: *** [sound/soc/sh/rcar/core.o] エラー 1
make[6]: *** 未完了のジョブを待っています....
make[5]: *** [sound/soc/sh/rcar] エラー 2
make[4]: *** [sound/soc/sh] エラー 2

This __rsnd_kctrl_new() is using "soc_card"...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/