linux-kernel - Re: [PATCH 4/8] platform: goldfish: pipe: add devicetree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151125112213.GB11346@lvm>
Date:	Wed, 25 Nov 2015 03:22:13 -0800
From:	Christoffer Dall <christoffer.dall@...aro.org>
To:	Jin Qian <jinqian@...roid.com>
Cc:	Greg Hackmann <ghackmann@...gle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alex Bennée <alex.bennee@...aro.org>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Jason Hu <jia-cheng.hu@...el.com>, Yu Ning <yu.ning@...el.com>,
	Joe Perches <joe@...ches.com>,
	Peter Senna Tschudin <peter.senna@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/8] platform: goldfish: pipe: add devicetree bindings

On Tue, Nov 24, 2015 at 05:10:08PM -0800, Jin Qian wrote:
> From: Greg Hackmann <ghackmann@...gle.com>
> 
> Signed-off-by: Greg Hackmann <ghackmann@...gle.com>
> (cherry picked from commit 3c56d07eb796066530e93a40e74dea3bc59bf4cf)
> Signed-off-by: Jin Qian <jinqian@...roid.com>
> ---
>  drivers/platform/goldfish/goldfish_pipe.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
> index 20a9337..86cc57f 100644
> --- a/drivers/platform/goldfish/goldfish_pipe.c
> +++ b/drivers/platform/goldfish/goldfish_pipe.c
> @@ -624,11 +624,19 @@ static int goldfish_pipe_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +static const struct of_device_id goldfish_pipe_of_match[] = {
> +	{ .compatible = "generic,android-pipe", },
> +	{},
> +};
> +MODULE_DEVICE_TABLE(of, goldfish_pipe_of_match);
> +
>  static struct platform_driver goldfish_pipe = {
>  	.probe = goldfish_pipe_probe,
>  	.remove = goldfish_pipe_remove,
>  	.driver = {
> -		.name = "goldfish_pipe"
> +		.name = "goldfish_pipe",
> +		.owner = THIS_MODULE,
> +		.of_match_table = goldfish_pipe_of_match,
>  	}
>  };
>  
I think this needs something documented in
Documentation/devicetree/bindings as well.

-Christoffer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/