lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Nov 2015 13:00:06 +0100 From: Johannes Thumshirn <jthumshirn@...e.de> To: Ching Huang <ching2048@...ca.com.tw> Cc: hch@....de, hch@...radead.org, thenzl@...hat.com, jbottomley@...allels.com, dan.carpenter@...cle.com, agordeev@...hat.com, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, hare@...e.de Subject: Re: [PATCH v3 2/5] arcmsr: fixes not release allocated resource On Wed, 2015-11-25 at 19:41 +0800, Ching Huang wrote: > From: Ching Huang <ching2048@...ca.com.tw> > > Releasing allocated resource if get configuration data failed. > > Signed-of-by: Ching Huang <ching2048@...ca.com.tw> > > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c > b/drivers/scsi/arcmsr/arcmsr_hba.c > --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2015-11-24 11:35:26.000000000 > +0800 > +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2015-11-25 19:04:44.590970000 > +0800 > @@ -2664,7 +2664,7 @@ static bool arcmsr_hbaB_get_config(struc > if (!arcmsr_hbaB_wait_msgint_ready(acb)) { > printk(KERN_NOTICE "arcmsr%d: wait 'get adapter firmware \ > miscellaneous data' timeout \n", acb->host- > >host_no); > - return false; > + goto err_free_dma; > } > count = 8; > while (count){ > @@ -2707,6 +2707,10 @@ static bool arcmsr_hbaB_get_config(struc > acb->firm_cfg_version = readl(®- > >message_rwbuffer[25]); /*firm_cfg_version,25,100-103*/ > /*firm_ide_channels,4,16-19*/ > return true; > +err_free_dma: > + dma_free_coherent(&acb->pdev->dev, acb->roundup_ccbsize, > + acb->dma_coherent2, acb->dma_coherent_handle2); > + return false; > } > > static bool arcmsr_hbaC_get_config(struct AdapterControlBlock *pACB) > > Reviewed-by: Johannes Thumshirn <jthumshirn@...e.de> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists