lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1448459006-6118-2-git-send-email-clabbe.montjoie@gmail.com>
Date:	Wed, 25 Nov 2015 14:43:23 +0100
From:	LABBE Corentin <clabbe.montjoie@...il.com>
To:	minyard@....org, openipmi-developer@...ts.sourceforge.net
Cc:	LABBE Corentin <clabbe.montjoie@...il.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH 2/4] ipmi: constify the reason parameter of start_error_recovery

Both start_error_recovery() function are different but they didn't
modify the reason parameter.
Furthermore, the reason parameter is always given string literal.

Signed-off-by: LABBE Corentin <clabbe.montjoie@...il.com>
---
 drivers/char/ipmi/ipmi_kcs_sm.c  | 2 +-
 drivers/char/ipmi/ipmi_smic_sm.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_kcs_sm.c b/drivers/char/ipmi/ipmi_kcs_sm.c
index 1da61af..9ec38e6 100644
--- a/drivers/char/ipmi/ipmi_kcs_sm.c
+++ b/drivers/char/ipmi/ipmi_kcs_sm.c
@@ -202,7 +202,7 @@ static inline void write_next_byte(struct si_sm_data *kcs)
 	(kcs->write_count)--;
 }
 
-static inline void start_error_recovery(struct si_sm_data *kcs, char *reason)
+static inline void start_error_recovery(struct si_sm_data *kcs, const char *reason)
 {
 	(kcs->error_retries)++;
 	if (kcs->error_retries > MAX_ERROR_RETRIES) {
diff --git a/drivers/char/ipmi/ipmi_smic_sm.c b/drivers/char/ipmi/ipmi_smic_sm.c
index 8f7c73f..21ad645 100644
--- a/drivers/char/ipmi/ipmi_smic_sm.c
+++ b/drivers/char/ipmi/ipmi_smic_sm.c
@@ -227,7 +227,7 @@ static inline void write_si_sm_data(struct si_sm_data *smic,
 	smic->io->outputb(smic->io, 0, data);
 }
 
-static inline void start_error_recovery(struct si_sm_data *smic, char *reason)
+static inline void start_error_recovery(struct si_sm_data *smic, const char *reason)
 {
 	(smic->error_retries)++;
 	if (smic->error_retries > SMIC_MAX_ERROR_RETRIES) {
-- 
2.4.10

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ