linux-kernel - Re: [PATCH v2 1/1] x86/platform/iosf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Nov 2015 16:33:04 +0200
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	linux-pm@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	Peter Anvin <hpa@...or.com>, Wolfram Sang <wsa@...-dreams.de>,
	Zhang Rui <rui.zhang@...el.com>,
	Eduardo Valentin <edubezval@...il.com>,
	Hock Leong Kweh <hock.leong.kweh@...el.com>
Subject: Re: [PATCH v2 1/1] x86/platform/iosf_mbi: Remove duplicate
 definitions

On Wed, 2015-11-25 at 15:20 +0100, Thomas Gleixner wrote:
> On Wed, 11 Nov 2015, Andy Shevchenko wrote:
> 
> > The read and write opcodes are global for all units on SoC and even
> across
> > Intel SoCs. Remove duplication of corresponding constants. At the
> same time
> > convert all current users.
> > 
> > No functional change.
> > 
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Cc: Ingo Molnar <mingo@...hat.com>
> > Cc: Peter Anvin <hpa@...or.com>
> > Cc: Wolfram Sang <wsa@...-dreams.de>
> > Cc: Zhang Rui <rui.zhang@...el.com>
> > Cc: Eduardo Valentin <edubezval@...il.com>
> > Cc: Hock Leong Kweh <hock.leong.kweh@...el.com>

Eduardo, Rui, can you provide your ACKs or comments about the patch?

> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > ---
> > Since v1:
> > - satisfy kbuild robot
> > 
> >  arch/x86/include/asm/iosf_mbi.h              | 49 +++++-----------
> ------
> >  arch/x86/platform/atom/punit_atom_debug.c    |  7 +---
> >  arch/x86/platform/intel-quark/imr.c          | 28 +++++--------
> >  drivers/i2c/busses/i2c-designware-baytrail.c | 17 +++-----
> >  drivers/powercap/intel_rapl.c                | 10 ++---
> >  drivers/thermal/intel_quark_dts_thermal.c    | 61 ++++++++++++++
> --------------
> >  drivers/thermal/intel_soc_dts_iosf.c         | 43 ++++++++++----
> ------
> 
> Hmm. Either we get acks of all maintainers and merge it through
> tip/x86/... 

I prefer this way because…

> or we do the following:
> 
> Add the new constants w/o using them in a seperate patch and ship
> that
> linuswards now. Then the subsystem maintainers can pick the
> individual
> patches up and after the merge window closes we remove the old
> constants in one go.
> 
> Either way works for me.

…we are working on another fix which is based also on this patch. Can
you provide your ACK if you are okay with the changes to arch/x86 ?

> 
> Thanks,
> 
>         tglx
> 
> 

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/