linux-kernel - Re: [PATCH 1/2] sp5100_tco: fix the device check for SB800 and later chipsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <565518D5.4010104@roeck-us.net>
Date:	Tue, 24 Nov 2015 18:11:33 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Huang Rui <ray.huang@....com>
Cc:	Wim Van Sebroeck <wim@...ana.be>, linux-watchdog@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Denis Turischev <denis.turischev@...pulab.co.il>,
	Borislav Petkov <bp@...en8.de>,
	Vincent Wan <vincent.wan@....com>, Tony Li <tony.li@....com>
Subject: Re: [PATCH 1/2] sp5100_tco: fix the device check for SB800 and later
 chipsets

On 11/24/2015 05:59 PM, Huang Rui wrote:
> On Tue, Nov 24, 2015 at 05:58:03AM -0800, Guenter Roeck wrote:
>> On 11/23/2015 02:07 AM, Huang Rui wrote:
>>> For SB800 and later chipsets, the register definitions are the same
>>> with SB800. And for SB700 and older chipsets, the definitions should
>>> be same with SP5100/SB7x0.
>>>
>>> Signed-off-by: Huang Rui <ray.huang@....com>
>>> Cc: Denis Turischev <denis.turischev@...pulab.co.il>
>>
>> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
>>
>> Would it make sense to rework this driver as pci driver ?
>>
>
> I agree with you. Actually, I thought about this stuff. But sp5100
> watchdog is not a pci device in AMD chipset. In another word, it
> doesn't export a pci header to OS. At current, we use SMBus pci device
> id and vendor id to detect watchdog on the AMD chipset (Because AMD
> use SMBus device id and revsion to identify different chipset
> version). At the same time, SMbus has its own driver piix4_smbus.
> Looks like we don't have a pci header to enumerate the watchdog.
>

Ok, thanks for the clarification. Odd way to detect the chip, but
I guess one has to use what is available.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/