linux-kernel - Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151125181618-mutt-send-email-mst@redhat.com>
Date:	Wed, 25 Nov 2015 18:22:10 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	"Lan, Tianyu" <tianyu.lan@...el.com>
Cc:	a.motakis@...tualopensystems.com, alex.williamson@...hat.com,
	b.reynal@...tualopensystems.com, bhelgaas@...gle.com,
	carolyn.wyborny@...el.com, donald.c.skidmore@...el.com,
	eddie.dong@...el.com, nrupal.jani@...el.com, agraf@...e.de,
	kvm@...r.kernel.org, pbonzini@...hat.com, qemu-devel@...gnu.org,
	emil.s.tantilov@...el.com, gerlitz.or@...il.com,
	mark.d.rustad@...el.com, eric.auger@...aro.org,
	intel-wired-lan@...ts.osuosl.org, jeffrey.t.kirsher@...el.com,
	jesse.brandeburg@...el.com, john.ronciak@...el.com,
	linux-api@...r.kernel.org, linux-kernel@...r.kernel.org,
	matthew.vick@...el.com, mitch.a.williams@...el.com,
	netdev@...r.kernel.org, shannon.nelson@...el.com,
	weiyang@...ux.vnet.ibm.com, zajec5@...il.com
Subject: Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf
 driver

On Thu, Nov 26, 2015 at 12:02:33AM +0800, Lan, Tianyu wrote:
> On 11/25/2015 8:28 PM, Michael S. Tsirkin wrote:
> >Frankly, I don't really see what this short term hack buys us,
> >and if it goes in, we'll have to maintain it forever.
> >
> 
> The framework of how to notify VF about migration status won't be
> changed regardless of stopping VF or not before doing migration.
> We hope to reach agreement on this first.

Well it's bi-directional, the framework won't work if it's
uni-directional.
Further, if you use this interface to stop the interface
at the moment, you won't be able to do anything else
with it, and will need a new one down the road.


> Tracking dirty memory still
> need to more discussions and we will continue working on it. Stop VF may
> help to work around the issue and make tracking easier.
> 
> 
> >Also, assuming you just want to do ifdown/ifup for some reason, it's
> >easy enough to do using a guest agent, in a completely generic way.
> >
> 
> Just ifdown/ifup is not enough for migration. It needs to restore some PCI
> settings before doing ifup on the target machine

I'd focus on just restoring then.

-- 
MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/