linux-kernel - Re: [PATCH 11/14] mmc: sdhci-pic32: Add PIC32 SDHC host controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFph3vDzDJCxZFZYGN2BsBcqSqhvsug5F_JUdEryNa9udw@mail.gmail.com>
Date:	Wed, 25 Nov 2015 17:38:57 +0100
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Joshua Henderson <joshua.henderson@...rochip.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-mips@...ux-mips.org,
	Andrei Pistirica <andrei.pistirica@...rochip.com>,
	Jean Delvare <jdelvare@...e.de>,
	Corneliu Doban <cdoban@...adcom.com>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Alim Akhtar <alim.akhtar@...sung.com>,
	Luis de Bethencourt <luisbg@....samsung.com>,
	Weijun Yang <Weijun.Yang@....com>,
	Lokesh Vutla <lokeshvutla@...com>,
	Scott Branden <sbranden@...adcom.com>,
	Vincent Yang <vincent.yang.fujitsu@...il.com>,
	Chaotian Jing <chaotian.jing@...iatek.com>,
	"ludovic.desroches@...el.com" <ludovic.desroches@...el.com>,
	Shawn Lin <shawn.lin@...k-chips.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	yangbo lu <yangbo.lu@...escale.com>,
	Kevin Hao <haokexin@...il.com>,
	Ben Hutchings <ben@...adent.org.uk>,
	Andy Green <andy.green@...aro.org>,
	linux-mmc <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH 11/14] mmc: sdhci-pic32: Add PIC32 SDHC host controller driver

[...]

>> +sdhci_pic32_probe_dts(struct platform_device *pdev,
>> +                     struct pic32_sdhci_pdata *boarddata)
>> +{
>> +       struct device_node *np = pdev->dev.of_node;
>> +
>> +       if (!np)
>> +               return -ENODEV;
>> +
>> +       if (of_find_property(np, "no-1-8-v", NULL))
>
> Please don't use this property as it's broken. It has two different
> purposes and those are conflicting as discussed here[1].

Realized that I forgot to attach the reference to the discussion, here it is.

[1]
http://comments.gmane.org/gmane.linux.kernel.mmc/32751

>
> You have two options, either invent a new binding which provides
> information about which signal voltage that *is* supported, or use the
> current existing common MMC dt bindings to override the SDHCI
> capabilities register.
>

[...]

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/