linux-kernel - Re: [RFC 1/1] xen: block: correct setting for xen_blkif_max_ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151125165345.GA19188@x230.dumpdata.com>
Date:	Wed, 25 Nov 2015 11:53:55 -0500
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Peng Fan <van.freenix@...il.com>
Cc:	xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	David Vrabel <david.vrabel@...rix.com>,
	Roger Pau Monné <roger.pau@...rix.com>
Subject: Re: [RFC 1/1] xen: block: correct setting for
 xen_blkif_max_ring_order

On Wed, Nov 25, 2015 at 06:26:01PM +0800, Peng Fan wrote:
> According to this piece code:
> "
>      pr_info("Invalid max_ring_order (%d), will use default max: %d.\n",
>               xen_blkif_max_ring_order, XENBUS_MAX_RING_GRANT_ORDER);
> "
> if xen_blkif_max_ring_order is bigger that XENBUS_MAX_RING_GRANT_ORDER,
> need to set xen_blkif_max_ring_order using XENBUS_MAX_RING_GRANT_ORDER,
> but not 0.
> 
> Signed-off-by: Peng Fan <van.freenix@...il.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> Cc: David Vrabel <david.vrabel@...rix.com>
> Cc: "Roger Pau Monné" <roger.pau@...rix.com>
> ---
> 
> Hi,
> 
> I am new to xen and reading related soure code, not sure whether
> this is correct. Please comments.

Applied to 'devel/for-jens-4.5'.

Thanks!
> 
> Thanks
> 
>  drivers/block/xen-blkfront.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 0823a96..883b9fa 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -2126,7 +2126,7 @@ static int __init xlblk_init(void)
>  	if (xen_blkif_max_ring_order > XENBUS_MAX_RING_PAGE_ORDER) {
>  		pr_info("Invalid max_ring_order (%d), will use default max: %d.\n",
>  			xen_blkif_max_ring_order, XENBUS_MAX_RING_PAGE_ORDER);
> -		xen_blkif_max_ring_order = 0;
> +		xen_blkif_max_ring_order = XENBUS_MAX_RING_PAGE_ORDER;
>  	}
>  
>  	if (!xen_has_pv_disk_devices())
> -- 
> 2.6.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/