lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Nov 2015 11:59:47 +0900 From: Joonsoo Kim <iamjoonsoo.kim@....com> To: Vlastimil Babka <vbabka@...e.cz> Cc: Andrew Morton <akpm@...ux-foundation.org>, Mel Gorman <mgorman@...e.de>, Yaowei Bai <bywxiaobai@....com>, linux-kernel@...r.kernel.org, linux-mm@...ck.org Subject: Re: [PATCH] mm/compaction: __compact_pgdat() code cleanuup On Tue, Nov 24, 2015 at 09:49:49AM +0100, Vlastimil Babka wrote: > On 11/24/2015 07:24 AM, Joonsoo Kim wrote: > >This patch uses is_via_compact_memory() to distinguish direct compaction. > >And it also reduces indentation on compaction_defer_reset > >by filtering failure case. There is no functional change. > > > >Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@....com> > >--- > > mm/compaction.c | 15 +++++++++------ > > 1 file changed, 9 insertions(+), 6 deletions(-) > > > >diff --git a/mm/compaction.c b/mm/compaction.c > >index de3e1e7..2b1a15e 100644 > >--- a/mm/compaction.c > >+++ b/mm/compaction.c > >@@ -1658,14 +1658,17 @@ static void __compact_pgdat(pg_data_t *pgdat, struct compact_control *cc) > > !compaction_deferred(zone, cc->order)) > > compact_zone(zone, cc); > > > >- if (cc->order > 0) { > >- if (zone_watermark_ok(zone, cc->order, > >- low_wmark_pages(zone), 0, 0)) > >- compaction_defer_reset(zone, cc->order, false); > >- } > >- > > VM_BUG_ON(!list_empty(&cc->freepages)); > > VM_BUG_ON(!list_empty(&cc->migratepages)); > >+ > >+ if (is_via_compact_memory(cc->order)) > >+ continue; > > That's fine. > > >+ if (!zone_watermark_ok(zone, cc->order, > >+ low_wmark_pages(zone), 0, 0)) > >+ continue; > >+ > >+ compaction_defer_reset(zone, cc->order, false); > > Here I'd personally find the way of "if(watermark_ok) defer_reset()" > logic easier to follow. Okay. Will change it. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists