linux-kernel - Re: [PATCH 1/2] ftrace: Add separate handler for ftrace:function event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151125124221.281d6f3d@gandalf.local.home>
Date:	Wed, 25 Nov 2015 12:42:21 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Jiri Olsa <jolsa@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...nel.org>
Subject: Re: [PATCH 1/2] ftrace: Add separate handler for ftrace:function
 event

On Wed, 25 Nov 2015 18:12:43 +0100
Jiri Olsa <jolsa@...hat.com> wrote:

> > Yeah, I'm trying to figure out the paths here. I would love to remove
> > the control_ops as that complicates the function tracing code a bit
> > more than I would like it to be.  
> 
> perf is using the control interface to enable and disable function
> tracing any time the process (and its events) is scheduled in/out
> 
> sched_in(event)  -> ftrace_function_local_enable(&event->ftrace_ops)
> sched_out(event) -> ftrace_function_local_disable(&event->ftrace_ops)

OK, I think we can merge the control list to the normal list and have
something like:

 (!op->disabled || !ftrace_function_local_disabled(op))

We can also keep the control flag for the ops, and have:

	!(op->flags & FTRACE_OPS_FL_CONTROL) || rcu_is_watching()

test too, and use the ftrace ops list code.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/