linux-kernel - Re: [PATCH v5 5/5] Add ioctls to enable and disable local controls on an instrument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcyAWE-32wNcTgX4r9H9Fp-fyCeLdjGH-YVWZCewgK6_g@mail.gmail.com>
Date:	Wed, 25 Nov 2015 22:46:28 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Dave Penkler <dpenkler@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	peter.chen@...escale.com, teuniz@...il.com,
	USB <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 5/5] Add ioctls to enable and disable local controls on
 an instrument

On Wed, Nov 25, 2015 at 11:12 AM, Dave Penkler <dpenkler@...il.com> wrote:
> On Sun, Nov 22, 2015 at 12:36:53PM +0200, Andy Shevchenko wrote:


> OK so now I have the same as in v4 again:
>
>         if (rv < 0) {
>                 dev_err(dev, "simple usb_control_msg failed %d\n", rv);
>                 goto exit;
>         } else if (rv != 1) {
>                 dev_warn(dev, "simple usb_control_msg returned %d\n", rv);
>                 rv = -EIO;
>                 goto exit;
>         }

This looks correct. Sorry if I misled you, but I really asked about
error code in the first place.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/