linux-kernel - Re: severe regression in alx ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151125224708.GA1640@electric-eye.fr.zoreil.com>
Date:	Wed, 25 Nov 2015 23:47:08 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Jarod Wilson <jarod@...hat.com>
Cc:	David Miller <davem@...emloft.net>, ldap.tester@...il.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: severe regression in alx ethernet driver

Jarod Wilson <jarod@...hat.com> :
[...]
> They do at least have a signed-off-by in the patches attached to the bug,
> so I'm working on touching up the descriptions and formatting, regression
> testing them on my laptop that has an alx-driven E2200 in it (which isn't
> affected by this bug), and then I can ship them up for proper review.

You can forget the last refill-me-harder patch and save a roundtrip.
The driver should 1) prohibit holes in its receive ring, 2) allocate before
pushing data up in the stack and 3) drop packets when it can't allocate a
fresh buffer.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/