linux-kernel - Re: [PATCH V3 net-next 2/5] net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5656B53B.3080205@huawei.com>
Date:	Thu, 26 Nov 2015 07:31:07 +0000
From:	Salil Mehta <salil.mehta@...wei.com>
To:	Yuval Mintz <Yuval.Mintz@...gic.com>,
	David Miller <davem@...emloft.net>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"paul.gortmaker@...driver.com" <paul.gortmaker@...driver.com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"catalin.marinas@....com" <catalin.marinas@....com>,
	"will.deacon@....com" <will.deacon@....com>,
	"arnd@...db.de" <arnd@...db.de>,
	"liguozhu@...ilicon.com" <liguozhu@...ilicon.com>,
	"yisen.zhuang@...wei.com" <yisen.zhuang@...wei.com>,
	"dingtianhong@...wei.com" <dingtianhong@...wei.com>,
	"zhangfei.gao@...aro.org" <zhangfei.gao@...aro.org>,
	"huangdaode@...ilicon.com" <huangdaode@...ilicon.com>,
	"kenneth-lee-2012@...mail.com" <kenneth-lee-2012@...mail.com>,
	"mehta.salil.lnk@...il.com" <mehta.salil.lnk@...il.com>,
	"xuwei5@...ilicon.com" <xuwei5@...ilicon.com>,
	"lisheng011@...wei.com" <lisheng011@...wei.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	netdev <netdev@...r.kernel.org>,
	"linuxarm@...wei.com" <linuxarm@...wei.com>
Subject: Re: [PATCH V3 net-next 2/5] net:hns: Add Hip06 "RSS(Receive Side
 Scaling)" support to HNS Driver


On 11/22/2015 9:30 AM, Yuval Mintz wrote:
>>   static void hns_ppe_init_hw(struct hns_ppe_cb *ppe_cb)  {
> ...
>> +	/* Set default RSS key and indrection table*/
>> +	const u32 rss_key[HNS_PPEV2_RSS_KEY_NUM] = {
>> +		0x6d5a56da, 0x255b0ec2,
>> +		0x4167253d, 0x43a38fb0,
>> +		0xd0ca2bcb, 0xae7b30b4,
>> +		0x77cb2da3, 0x8030f20c,
>> +		0x6a42b73b, 0xbeac01fa,
>> +	};
>> +
>> +	/* set default RSS key and remember it */
>> +	for (i = 0; i < HNS_PPEV2_RSS_KEY_NUM; i++)
>> +		ppe_cb->rss_key[i]  = rss_key[i];
>>
> Is there any reason for the special default key?
> Why not use netdev_rss_key_fill()?
Thanks for pointing out this. I have incorported this change in latest 
PATCH V5
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/