linux-kernel - Re: [PATCH v2] USB: serial: cp210x: Add tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Nov 2015 08:47:18 +0100
From:	Johan Hovold <johan@...nel.org>
To:	Andy Shevchenko <andy.shevchenko@...il.com>,
	Konstantin Shkolnyy <konstantin.shkolnyy@...il.com>
Cc:	johan@...nel.org, USB <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] USB: serial: cp210x: Add tx_empty()

On Thu, Nov 26, 2015 at 08:35:12AM +0100, Johan Hovold wrote:
> On Wed, Nov 25, 2015 at 10:26:12PM +0200, Andy Shevchenko wrote:
> > On Wed, Nov 25, 2015 at 12:28 AM, Konstantin Shkolnyy
> > <konstantin.shkolnyy@...il.com> wrote:
> > > Added tx_empty callback needed for generic wait-until-sent support.
> > > Without this function, when the port is closed usbserial can't know that
> > > there are still data in the chip's transmit FIFO. The chip gets disabled
> > > and untransmitted data lost. When the actual byte count is reported by
> > > tx-empty the close can be delayed until all data are sent.

> > Btw, can be count left uninitialized?
> 
> Yes, but that's not an issue. Clearly separating the success and errors
> paths as I suggested above would make that more obvious however.
> 
> I'll fix that up before applying.

Now applied, thanks.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/