lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Nov 2015 16:13:06 -0800 From: Andrew Duggan <aduggan@...aptics.com> To: Benjamin Tissoires <benjamin.tissoires@...il.com>, Dmitry Torokhov <dmitry.torokhov@...il.com> CC: linux-input <linux-input@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Benjamin Tissoires <benjamin.tissoires@...hat.com>, Linus Walleij <linus.walleij@...aro.org>, Christopher Heiny <cheiny@...aptics.com>, Stephen Chandler Paul <cpaul@...hat.com> Subject: Re: [PATCH 02/26] Input: synaptics-rmi4 - add a common input device in rmi_driver On 11/10/2015 01:23 AM, Benjamin Tissoires wrote: > On Tue, Nov 10, 2015 at 12:13 AM, Dmitry Torokhov > <dmitry.torokhov@...il.com> wrote: > diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input/rmi4/rmi_f01.c > index ee5f4a1..2d72dc8 100644 > --- a/drivers/input/rmi4/rmi_f01.c > +++ b/drivers/input/rmi4/rmi_f01.c > @@ -176,6 +176,13 @@ static int rmi_f01_read_properties(struct rmi_device *rmi_dev, > return 0; > } > > +char *rmi_f01_get_product_ID(struct rmi_function *fn) > +{ > + struct f01_data *f01 = dev_get_drvdata(&fn->dev); > + > + return f01->properties.product_id; > +} >> Should we have something like rmi_to_input_id() that is similar to >> usb_to_input_id()? > Works for me. > In the patch set I just submitted I did not implement a rmi_to_input_id() function mostly because the product id in RMI is a string with a few possible formats. There isn't really a good way to convert it into a u16 which is what struct input_id is expecting. We would still need a function to return the string so I just left it the way it is. Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists