linux-kernel - Re: [PATCH] remoteproc: avoid stack overflow in debugfs file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK=WgbYafpVNBoCtsOBfuMn9OqBW_RP9=2Px8q-homVXLGQUpw@mail.gmail.com>
Date:	Thu, 26 Nov 2015 10:14:02 +0200
From:	Ohad Ben-Cohen <ohad@...ery.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm <linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Fernando Guzman Lugo <fernando.lugo@...com>,
	Fernando Guzman Lugo <fernando.guzman.lugo@...el.com>
Subject: Re: [PATCH] remoteproc: avoid stack overflow in debugfs file

On Fri, Nov 20, 2015 at 7:26 PM, Arnd Bergmann <arnd@...db.de> wrote:
> Recent gcc versions warn about reading from a negative offset of
> an on-stack array:
>
> drivers/remoteproc/remoteproc_debugfs.c: In function 'rproc_recovery_write':
> drivers/remoteproc/remoteproc_debugfs.c:167:9: warning: 'buf[4294967295u]' may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> I don't see anything in sys_write() that prevents us from
> being called with a zero 'count' argument, so we should
> add an extra check in rproc_recovery_write() to prevent the
> access and avoid the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 2e37abb89a2e ("remoteproc: create a 'recovery' debugfs entry")

Applied to remoteproc-fixes, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/