linux-kernel - Re: [PATCH] efi/esrt: don't preformat name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151126102708.GE2765@codeblueprint.co.uk>
Date:	Thu, 26 Nov 2015 10:27:08 +0000
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Peter Jones <pjones@...hat.com>
Subject: Re: [PATCH] efi/esrt: don't preformat name

On Fri, 20 Nov, at 11:30:17AM, Rasmus Villemoes wrote:
> kobject_init_and_add takes a format string+args, so there's no reason
> to do this formatting in advance.
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---
>  drivers/firmware/efi/esrt.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
 
Looks good to me. Thanks applied!

> diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
> index 22c5285f7705..75feb3f5829b 100644
> --- a/drivers/firmware/efi/esrt.c
> +++ b/drivers/firmware/efi/esrt.c
> @@ -167,14 +167,11 @@ static struct kset *esrt_kset;
>  static int esre_create_sysfs_entry(void *esre, int entry_num)
>  {
>  	struct esre_entry *entry;
> -	char name[20];
>  
>  	entry = kzalloc(sizeof(*entry), GFP_KERNEL);
>  	if (!entry)
>  		return -ENOMEM;
>  
> -	sprintf(name, "entry%d", entry_num);
> -
>  	entry->kobj.kset = esrt_kset;
>  
>  	if (esrt->fw_resource_version == 1) {
> @@ -182,7 +179,7 @@ static int esre_create_sysfs_entry(void *esre, int entry_num)
>  
>  		entry->esre.esre1 = esre;
>  		rc = kobject_init_and_add(&entry->kobj, &esre1_ktype, NULL,
> -					  "%s", name);
> +					  "entry%d", entry_num);
>  		if (rc) {
>  			kfree(entry);
>  			return rc;
> -- 
> 2.6.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/