linux-kernel - Re: MPT2SAS boot fail... due to silently loosing the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151126104823.GA8745@gmail.com>
Date:	Thu, 26 Nov 2015 11:48:23 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	"Martin K. Petersen" <martin.petersen@...cle.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Sreekanth.Reddy@...gotech.com, hch@....de, hare@...e.de,
	linux-kernel@...r.kernel.org
Subject: Re: MPT2SAS boot fail... due to silently loosing the driver


* Martin K. Petersen <martin.petersen@...cle.com> wrote:

> >>>>> "Peter" == Peter Zijlstra <peterz@...radead.org> writes:
> 
> Peter> Please either create a fake MPT2SAS config that selects the
> Peter> MPT3SAS driver, or rename the whole thing to MPT23SAS such that
> Peter> we at least get a relevant question on oldconfig.
> 
> Sorry about that, Peter.
> 
> I get bitten by oldconfig all the time so I have a script to manage all
> my configs. But it it would be nice if we had a way to express config
> options transitions in kbuild.
> 
> I guess we could do something like the following and let it sit for a
> release cycle to help people transition. Bit of a hack, but it worked
> for me in my quick testing...
> 
> -- 
> Martin K. Petersen	Oracle Linux Engineering
> 
> diff --git a/drivers/scsi/mpt3sas/Kconfig b/drivers/scsi/mpt3sas/Kconfig
> index 29061467cc17..901c97f1e368 100644
> --- a/drivers/scsi/mpt3sas/Kconfig
> +++ b/drivers/scsi/mpt3sas/Kconfig
> @@ -48,6 +48,13 @@ config SCSI_MPT3SAS
>  	---help---
>  	This driver supports PCI-Express SAS 12Gb/s Host Adapters.
>  
> +config SCSI_MPT2SAS
> +	tristate
> +	default n
> +	select SCSI_MPT3SAS
> +	---help---
> +	Dummy config option for backwards compatiblity.

So I don't think this does what you expect it to do: non-interactive options will 
be set to their defaults, regardless of what's in the oldconfig.

So you need to make it interactive, with a short help text that explains to users 
that this is legacy option only, and that they should enable the MPT3SAS option if 
they want to configure things manually.

i.e. something like:

+config SCSI_MPT2SAS
+	tristate "Legacy MPT2SAS config option"
+	default n
+	select SCSI_MPT3SAS
+	---help---
+	Dummy config option for backwards compatiblity: configure the MPT3SAS 
+	driver instead.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/