linux-kernel - Re: block: Always check queue limits for cloned requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151126131104.GA24297@redhat.com>
Date:	Thu, 26 Nov 2015 08:11:05 -0500
From:	Mike Snitzer <snitzer@...hat.com>
To:	Hannes Reinecke <hare@...e.de>
Cc:	Jens Axboe <axboe@...com>, linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org, Christoph Hellwig <hch@....de>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Ewan Milne <emilne@...hat.com>, Jeff Moyer <jmoyer@...hat.com>
Subject: Re: block: Always check queue limits for cloned requests

On Thu, Nov 26 2015 at  2:46am -0500,
Hannes Reinecke <hare@...e.de> wrote:

> When a cloned request is retried on other queues it always needs
> to be checked against the queue limits of that queue.
> Otherwise the calculations for nr_phys_segments might be wrong,
> leading to a crash in scsi_init_sgtable().
> 
> To clarify this the patch renames blk_rq_check_limits()
> to blk_cloned_rq_check_limits() and removes the symbol
> export, as the new function should only be used for
> cloned requests and never exported.
> 
> Cc: Mike Snitzer <snitzer@...hat.com>
> Cc: Ewan Milne <emilne@...hat.com>
> Cc: Jeff Moyer <jmoyer@...hat.com>
> Signed-off-by: Hannes Reinecke <hare@...e.de>

Patch looks good.  Thanks for getting to the bottom of this.

Jens, please add these extra tags when you pick this up:

Fixes: e2a60da74 ("block: Clean up special command handling logic")
Cc: stable@...r.kernel.org # 3.7+
Acked-by: Mike Snitzer <snitzer@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/