[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20151126134340.GB8644@n2100.arm.linux.org.uk>
Date: Thu, 26 Nov 2015 13:43:40 +0000
From: Russell King - ARM Linux <linux@....linux.org.uk>
To: Maarten Lankhorst <maarten.lankhorst@...onical.com>,
Daniel Vetter <daniel@...ll.ch>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
Sumit Semwal <sumit.semwal@...aro.org>
Cc: linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
dri-devel@...ts.freedesktop.org
Subject: reservation.h: build error with lockdep disabled
As of 3c3b177a9369 ("reservation: add suppport for read-only access
using rcu") linux/reservation.h uses lockdep macros:
+#define reservation_object_held(obj) lockdep_is_held(&(obj)->lock.base)
This results in build errors when lockdep is disabled as lockdep_is_held()
is only available when lockdep is enabled. This has been reported today
to break the etnaviv kernel driver, which we're hoping to submit for 4.5.
As this gets used with rcu_dereference_protected(), eg:
static inline struct reservation_object_list *
reservation_object_get_list(struct reservation_object *obj)
{
return rcu_dereference_protected(obj->fence,
reservation_object_held(obj));
}
I'm guessing that it's not going to be a simple case of making it always
return true or always return false.
Any ideas how to solve this?
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists