lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Nov 2015 18:15:53 -0800 From: Shawn N <shawnn@...omium.org> To: joe@...ches.com Cc: linux-kernel@...r.kernel.org Subject: checkpatch: GIT_COMMIT_ID rule catches 'cherry picked from commit <sha1>' lines Hello, The checkpatch.pl GIT_COMMIT_ID rule appears to be designed to enforce a minimum description when citing patches: 'commit <12+ chars of sha1> (\"<title line>\")'. One (unintended?) consequence of this rule is that unmodified 'cherry picked from commit <sha1>' (git cherry-pick -x) lines are flagged. - Is the disallowing of 'cherry picked from commit <sha1>' lines by GIT_COMMIT_ID working as intended? - If yes, would it be acceptable to instead add a new rule with clearer error output ("Don't include git cherry-pick -x description lines")? - If no (and such lines are actually acceptable) then I will just patch the GIT_COMMIT_ID rule. Thanks, Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists