linux-kernel - Re: Deadlock in n_hdlc_buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56574CCA.8010807@suse.cz>
Date:	Thu, 26 Nov 2015 19:17:46 +0100
From:	Jiri Slaby <jslaby@...e.cz>
To:	Dmitry Vyukov <dvyukov@...gle.com>, paulkf@...rogate.com,
	LKML <linux-kernel@...r.kernel.org>
Cc:	Eric Dumazet <edumazet@...gle.com>,
	Alexander Potapenko <glider@...gle.com>,
	Kostya Serebryany <kcc@...gle.com>,
	syzkaller <syzkaller@...glegroups.com>,
	Sasha Levin <sasha.levin@...cle.com>
Subject: Re: Deadlock in n_hdlc_buf_put

On 11/26/2015, 01:37 PM, Dmitry Vyukov wrote:
> [  341.376188] =============================================
> [  341.376607] [ INFO: possible recursive locking detected ]
> [  341.376607] 4.4.0-rc1+ #117 Not tainted
> [  341.376607] ---------------------------------------------
> [  341.376607] syzkaller_execu/14066 is trying to acquire lock:
> [  341.376607]  (&(&list->spinlock)->rlock){......}, at:
> [<ffffffff82a9f548>] n_hdlc_buf_put+0x28/0x170
> [  341.376607]
> [  341.376607] but task is already holding lock:
> [  341.376607]  (&(&list->spinlock)->rlock){......}, at:
> [<ffffffff82aa1368>] n_hdlc_tty_ioctl+0x2b8/0x3f0
> [  341.376607]
> [  341.376607] other info that might help us debug this:
> [  341.376607]  Possible unsafe locking scenario:
> [  341.376607]
> [  341.376607]        CPU0
> [  341.376607]        ----
> [  341.376607]   lock(&(&list->spinlock)->rlock);
> [  341.376607]   lock(&(&list->spinlock)->rlock);

Hi,

this is a lockdep false positive. The first one is tx_buf_list.spinlock,
the latter tx_free_buf_list.spinlock, both in flush_tx_queue. So we need
a lockdep annotation here.

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/