lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Nov 2015 10:42:53 +0800 From: bayi cheng <bayi.cheng@...iatek.com> To: Daniel Kurtz <djkurtz@...omium.org> CC: David Woodhouse <dwmw2@...radead.org>, Brian Norris <computersforpeace@...il.com>, Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Matthias Brugger <matthias.bgg@...il.com>, Sascha Hauer <s.hauer@...gutronix.de>, "open list:OPEN FIRMWARE AND..." <devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, <linux-mediatek@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, <linux-mtd@...ts.infradead.org>, srv_heupstream <srv_heupstream@...iatek.com>, <jteki@...nedev.com>, <ezequiel@...guardiasur.com.ar> Subject: Re: [PATCH v8 2/2] arm64: dts: mt8173: Add nor flash node On Thu, 2015-11-26 at 09:20 +0800, Daniel Kurtz wrote: > Hi Bayi, Matthias, > > Sorry for the late review, one comment below... > > On Wed, Nov 18, 2015 at 11:30 AM, Bayi Cheng <bayi.cheng@...iatek.com> wrote: > > Add Mediatek nor flash node > > > > Signed-off-by: Bayi Cheng <bayi.cheng@...iatek.com> > > Acked-by: Brian Norris <computersforpeace@...il.com> > > --- > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 18 +++++++++++++++++- > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > index 4dd5f93..7988656 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > @@ -387,7 +387,23 @@ > > status = "disabled"; > > }; > > > > - i2c3: i2c@...10000 { > > + nor_flash: spi@...0d000 { > > + compatible = "mediatek,mt8173-nor"; > > + reg = <0 0x1100d000 0 0xe0>; > > + clocks = <&pericfg CLK_PERI_SPI>, > > + <&topckgen CLK_TOP_SPINFI_IFR_SEL>; > > + clock-names = "spi", "sf"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + status = "disabled"; > > + > > + flash@0 { > > + compatible = "jedec,spi-nor"; > > + reg = <0>; > > + }; > > I think this flash@0 node represents the flash device present on the > board and should therefore be moved to the board-specific .dts. > > -Dan > Hi Daniel, Thanks for your comments, and I will fixed it in the next patch. > > + }; > > + > > + i2c3: i2c3@...10000 { > > compatible = "mediatek,mt8173-i2c"; > > reg = <0 0x11010000 0 0x70>, > > <0 0x11000280 0 0x80>; > > -- > > 1.8.1.1.dirty > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists