lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Nov 2015 11:16:08 +0800 From: Xinwei Kong <kong.kongxinwei@...ilicon.com> To: Shawn Guo <shawnguo@...nel.org> CC: <robh+dt@...nel.org>, <pawel.moll@....com>, <mark.rutland@....com>, <galak@...eaurora.org>, <catalin.marinas@....com>, <will.deacon@....com>, <tyler.baker@...aro.org>, <arnd@...db.de>, <bintian.wang@...wei.com>, <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>, <puck.chen@...ilicon.com>, <liguozhu@...ilicon.com>, <w.f@...wei.com> Subject: Re: [PATCH 1/1] arm64: dts: add all hi6220 i2c nodes hi Shawn, On 2015/11/25 20:24, Shawn Guo wrote: > On Wed, Nov 25, 2015 at 05:49:02PM +0800, Xinwei Kong wrote: >> This patch adds all I2C nodes for the Hi6220 SoC. This hi6220 Soc >> use this I2C IP of Synopsys Designware for HiKey board. >> >> Signed-off-by: Xinwei Kong <kong.kongxinwei@...ilicon.com> >> Signed-off-by: Chen Feng <puck.chen@...ilicon.com> >> --- >> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 37 +++++++++++++++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> index 82d2488..6b591a9 100644 >> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> @@ -208,5 +208,42 @@ >> clock-names = "uartclk", "apb_pclk"; >> status = "disabled"; >> }; >> + >> + i2c0: i2c@...00000 { >> + compatible = "snps,designware-i2c"; >> + reg = <0x0 0xf7100000 0x0 0x1000>; >> + interrupts = <0 44 4>; >> + clocks = <&sys_ctrl HI6220_I2C0_CLK>; >> + clock-names = "clk_i2c0"; >> + i2c-sda-hold-time-ns = <300>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>; >> + status = "ok"; > > Shouldn't it be set "disabled" in <soc>.dtsi and let <board>.dts enable > it per board design? > > Shawn get it. thank you xinwei > >> + }; >> + >> + i2c1: i2c@...01000 { >> + compatible = "snps,designware-i2c"; >> + reg = <0x0 0xf7101000 0x0 0x1000>; >> + interrupts = <0 45 4>; >> + clocks = <&sys_ctrl HI6220_I2C1_CLK>; >> + clock-names = "clk_i2c1"; >> + i2c-sda-hold-time-ns = <300>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&i2c1_pmx_func &i2c1_cfg_func>; >> + status = "ok"; >> + }; >> + >> + i2c2: i2c@...02000 { >> + compatible = "snps,designware-i2c"; >> + reg = <0x0 0xf7102000 0x0 0x1000>; >> + interrupts = <0 46 4>; >> + clocks = <&sys_ctrl HI6220_I2C2_CLK>; >> + clock-names = "clk_i2c2"; >> + i2c-sda-hold-time-ns = <300>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&i2c2_pmx_func &i2c2_cfg_func>; >> + status = "ok"; >> + }; >> + >> }; >> }; >> -- >> 1.9.1 >> >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@...ts.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists