lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Nov 2015 21:14:36 -0800 From: Ray Jui <rjui@...adcom.com> To: Marc Zyngier <marc.zyngier@....com> CC: Bjorn Helgaas <bhelgaas@...gle.com>, Arnd Bergmann <arnd@...db.de>, Hauke Mehrtens <hauke@...ke-m.de>, <linux-kernel@...r.kernel.org>, <bcm-kernel-feedback-list@...adcom.com>, <linux-pci@...r.kernel.org> Subject: Re: [PATCH v2 4/5] PCI: iproc: Add iProc PCIe MSI support Hi Marc, On 11/25/2015 5:52 PM, Ray Jui wrote: > Hi Marc, > [...] >>> + /* reserve memory for MSI posted writes */ >>> + msi->msi_cpu = dma_alloc_coherent(pcie->dev, >>> + msi->nr_msi_region * MSI_MEM_REGION_SIZE, >>> + &msi->msi_dma, GFP_KERNEL); >> >> Same here. Also, what is the exact purpose of that memory? You have a >> coherent mapping with the CPU, but you never read from it. So what's >> the point? >> > > Yeah I guess I can change this back to kmalloc since coherent memory is > a scarce resource, and the CPU does not need to access the memory, so > there's no cache issue. > > I know I have not answered the first part of your question. Let me do > some experiments first and I'll get back to you on that, :) > I did some experiment with the msi_dma here. It looks like it can be any address as long as it's 4K aligned (i.e., can be from the device address range instead of the RAM address range). The MSI message data actually goes to the memory allocated for the event queue (makes sense...), and never made it to the MSI page memory allocated here. Our arch doc is just confusing....:( I saw your comment on the other email thread with Xilinx MSI. I'll set the address to the base address of the iProc PCIe controller (which is always 4K aligned). [...] >> >> Thanks, >> >> M. >> > > Thanks, Marc! > > Ray Thanks again! Ray -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists