lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Nov 2015 16:25:44 +1100 From: Michael Ellerman <mpe@...erman.id.au> To: Geliang Tang <geliangtang@....com>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Paul Mackerras <paulus@...ba.org>, Scott Wood <scottwood@...escale.com>, David Gibson <david@...son.dropbear.id.au> Cc: linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 7/7] powerpc: fix a problematic usage of WARN() On Wed, 2015-11-25 at 21:12 +0800, Geliang Tang wrote: > WARN() takes a condition and a format string. The condition was > omitted. So I added it. > > Signed-off-by: Geliang Tang <geliangtang@....com> > --- > arch/powerpc/kernel/setup_64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c > index 5c03a6a..726a9fb 100644 > --- a/arch/powerpc/kernel/setup_64.c > +++ b/arch/powerpc/kernel/setup_64.c > @@ -127,7 +127,7 @@ static void setup_tlb_core_data(void) > !mmu_has_feature(MMU_FTR_USE_TLBRSRV) && > book3e_htw_mode != PPC_HTW_E6500) { > /* Should we panic instead? */ > - WARN_ONCE("%s: unsupported MMU configuration -- expect problems\n", > + WARN_ONCE(1, "%s: unsupported MMU configuration -- expect problems\n", > __func__); > } > } Oh yuck. Acked-by: Michael Ellerman <mpe@...erman.id.au> cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists