lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 27 Nov 2015 10:31:20 +0800 From: "majun (F)" <majun258@...wei.com> To: Marc Zyngier <marc.zyngier@....com>, LKML <linux-kernel@...r.kernel.org>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org> Subject: ARM: Question about irq-gic-v3-its.c Hi Marc: I think there is a bug in current its_alloc_tables(). When "val |= alloc_pages - 1;" is called the "alloc_pages" is not updated accroding to "psz" value. I mean we need do alloc_pages = (alloc_size / psz); Further more, I also have a question about GITS_CBASER register. In gic-v3 spec: Bits [7:0]. Size. The number of '4kB' pages of physical memory provided for the command queue, minus one. But In its_alloc_tables() function, alloc_pages = (alloc_size / psz); // majun: pze = 64KB if (alloc_pages > GITS_BASER_PAGES_MAX) { alloc_pages = GITS_BASER_PAGES_MAX; order = get_order(GITS_BASER_PAGES_MAX * psz); pr_warn("ITS@...lx: Device Table too large, reduce its page order to %u (%u pages)\n", its->phys_base, order, alloc_pages); } GITS_BASER_PAGES_MAX = 256 I think this value means the maximum page number of 4KB ,right ? But when calc alloc_pages for first time, the psz = 64KB. So, I think maybe this is a bug too. Thanks! Ma Jun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists