lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 27 Nov 2015 12:09:44 +0800 From: yalin wang <yalin.wang2010@...il.com> To: mingo@...hat.com, peterz@...radead.org, linux-kernel@...r.kernel.org Cc: yalin wang <yalin.wang2010@...il.com> Subject: [PATCH] sched: change nr_uninterruptible to be signed nr_uninterruptible will be negative during running, this happened when dequeue a TASK_UNINTERRUPTIBLE task from rq1 and then wake up the task and queue it to rq2, then rq2->nr_uninterruptible-- will reuslt in negative value sometimes. Signed-off-by: yalin wang <yalin.wang2010@...il.com> --- kernel/sched/loadavg.c | 2 +- kernel/sched/sched.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/sched/loadavg.c b/kernel/sched/loadavg.c index ef71590..39504c6 100644 --- a/kernel/sched/loadavg.c +++ b/kernel/sched/loadavg.c @@ -83,7 +83,7 @@ long calc_load_fold_active(struct rq *this_rq) long nr_active, delta = 0; nr_active = this_rq->nr_running; - nr_active += (long)this_rq->nr_uninterruptible; + nr_active += this_rq->nr_uninterruptible; if (nr_active != this_rq->calc_load_active) { delta = nr_active - this_rq->calc_load_active; diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 84d4879..7b5f67b 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -605,7 +605,7 @@ struct rq { * one CPU and if it got migrated afterwards it may decrease * it on another CPU. Always updated under the runqueue lock: */ - unsigned long nr_uninterruptible; + long nr_uninterruptible; struct task_struct *curr, *idle, *stop; unsigned long next_balance; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists