lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 27 Nov 2015 15:11:58 +0100 From: Ulf Hansson <ulf.hansson@...aro.org> To: Ludovic Desroches <ludovic.desroches@...el.com> Cc: linux-mmc <linux-mmc@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Nicolas Ferre <nicolas.ferre@...el.com> Subject: Re: [PATCH] mmc: sdhci-of-at91: controller is suspended too early On 26 November 2015 at 17:41, Ludovic Desroches <ludovic.desroches@...el.com> wrote: > When calling sdhci_add_host(), the controller is already suspended. It > causes to read 0 in registers. > Increment the device's usage counter before calling sdhci_add_host(), > decrement it after and put it in suspend if it is possible. > > Signed-off-by: Ludovic Desroches <ludovic.desroches@...el.com> > Fixes: "mmc: sdhci-of-at91: add PM support" Thanks, applied for next! Actually I decided to squash this change into the "Fixes commit" itself, thus not breaking bisecting. Kind regards Uffe > --- > drivers/mmc/host/sdhci-of-at91.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c > index 81ab9db..7e7d8f0 100644 > --- a/drivers/mmc/host/sdhci-of-at91.c > +++ b/drivers/mmc/host/sdhci-of-at91.c > @@ -200,6 +200,7 @@ static int sdhci_at91_probe(struct platform_device *pdev) > > sdhci_get_of_property(pdev); > > + pm_runtime_get_noresume(&pdev->dev); > pm_runtime_set_active(&pdev->dev); > pm_runtime_enable(&pdev->dev); > pm_runtime_set_autosuspend_delay(&pdev->dev, 50); > @@ -209,6 +210,8 @@ static int sdhci_at91_probe(struct platform_device *pdev) > if (ret) > goto pm_runtime_disable; > > + pm_runtime_put_autosuspend(&pdev->dev); > + > return 0; > > pm_runtime_disable: > -- > 2.5.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists