linux-kernel - [bug] mei_fasync() bogosity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20151127042237.GW22011@ZenIV.linux.org.uk>
Date:	Fri, 27 Nov 2015 04:22:39 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Tomas Winkler <tomas.winkler@...el.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: [bug] mei_fasync() bogosity

in "mei: implement fasync for event notification" a ->fasync() instance is
added as

static int mei_fasync(int fd, struct file *file, int band)
{

	struct mei_cl *cl = file->private_data;

	if (!mei_cl_is_connected(cl))
		return POLLERR;

	return fasync_helper(fd, file, band, &cl->ev_async);
}

Valid return values for ->fasync() are 0, 1 and -E...; 8 (aka POLLERR) is not.
What had been intended there?  -ENODEV?  Some other error?  As it is, the
thing is broken.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/