linux-kernel - Re: [PATCH v2 1/1] platform: goldfish: pipe: add devicetree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56589E48.9000708@google.com>
Date:	Fri, 27 Nov 2015 10:17:44 -0800
From:	Greg Hackmann <ghackmann@...gle.com>
To:	Christoffer Dall <christoffer.dall@...aro.org>,
	Rob Herring <robh@...nel.org>
Cc:	Jin Qian <jinqian@...roid.com>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Joe Perches <joe@...ches.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Peter Senna Tschudin <peter.senna@...il.com>,
	Alex Bennée <alex.bennee@...aro.org>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] platform: goldfish: pipe: add devicetree bindings

On 11/26/15 12:34 AM, Christoffer Dall wrote:
> On Wed, Nov 25, 2015 at 02:24:16PM -0600, Rob Herring wrote:
>>
>> The binding may be trivial, but there's a bigger question of whether
>> this is the right long term direction. For example is upstream QEMU
>> going to take all the Android pipe stuff? Couldn't virtio be used here
>> as the transport?
>>
>
> But I wonder if that should really block this from being merged?  The
> support may not be in QEMU but it's in the Android emulator and it would
> be a less broken implementation with these patches in the kernel than
> without, I think.
>
> -Christoffer
>

To add to Christoffer's point, we added these bindings so we don't need 
to rely on the goldfish virtual bus for probing anymore.

Switching from the goldfish virtual bus to Device-Tree already 
eliminates one big piece where the Android emulator has diverged from 
upstream qemu.  And on the kernel side, it means we don't need ARM and 
MIPS goldfish board code to instantiate the bus.

In the long term I'm happy to push the SDK team towards replacing the 
Android pipe with a virtio alternative.  (We've already been switching 
over to virtio for things like storage.)  But in the short term, we 
still need it.  And I don't think it benefits the mainline kernel if we 
have to maintain cleanup patches like this out-of-tree.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/