linux-kernel - Re: [PATCH 2/5] dt-bindings: mediatek: Modify pinctrl bindings for mt2701

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Nov 2015 14:38:00 -0600
From:	Rob Herring <robh@...nel.org>
To:	Biao Huang <biao.huang@...iatek.com>
Cc:	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, linux-gpio@...r.kernel.org,
	srv_heupstream@...iatek.com
Subject: Re: [PATCH 2/5] dt-bindings: mediatek: Modify pinctrl bindings for
 mt2701

On Thu, Nov 26, 2015 at 04:44:29PM +0800, Biao Huang wrote:
> Signed-off-by: Biao Huang <biao.huang@...iatek.com>
> ---
>  .../devicetree/bindings/pinctrl/pinctrl-mt65xx.txt |    9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt
> index 0480bc3..ca6a27a 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt
> @@ -4,10 +4,11 @@ The Mediatek's Pin controller is used to control SoC pins.
>  
>  Required properties:
>  - compatible: value should be one of the following.
> -    (a) "mediatek,mt8135-pinctrl", compatible with mt8135 pinctrl.
> -    (b) "mediatek,mt8173-pinctrl", compatible with mt8173 pinctrl.
> -    (c) "mediatek,mt6397-pinctrl", compatible with mt6397 pinctrl.
> -    (d) "mediatek,mt8127-pinctrl", compatible with mt8127 pinctrl.
> +    (a) "mediatek,mt2701-pinctrl", compatible with mt2701 pinctrl.
> +    (b) "mediatek,mt6397-pinctrl", compatible with mt6397 pinctrl.
> +    (c) "mediatek,mt8135-pinctrl", compatible with mt8135 pinctrl.
> +    (d) "mediatek,mt8173-pinctrl", compatible with mt8173 pinctrl.
> +    (e) "mediatek,mt8127-pinctrl", compatible with mt8127 pinctrl.

If you were trying to sort these, they still aren't quite sorted. There 
is no point in sorting if you number (or letter) them because you will 
have to update many lines on any change. So drop the (a), (b), (c), etc.

Rob

>  - pins-are-numbered: Specify the subnodes are using numbered pinmux to
>    specify pins.
>  - gpio-controller : Marks the device node as a gpio controller.
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/