lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Nov 2015 23:25:11 -0600 From: "Serge E. Hallyn" <serge.hallyn@...ntu.com> To: Tejun Heo <tj@...nel.org> Cc: serge@...lyn.com, linux-kernel@...r.kernel.org, adityakali@...gle.com, linux-api@...r.kernel.org, containers@...ts.linux-foundation.org, cgroups@...r.kernel.org, lxc-devel@...ts.linuxcontainers.org, akpm@...ux-foundation.org, ebiederm@...ssion.com Subject: Re: [PATCH 1/8] kernfs: Add API to generate relative kernfs path On Tue, Nov 24, 2015 at 11:16:30AM -0500, Tejun Heo wrote: > Hello, > > On Mon, Nov 16, 2015 at 01:51:38PM -0600, serge@...lyn.com wrote: > > +static char * __must_check kernfs_path_from_node_locked( (Note I've rewritten this to find a common ancestor and walk back to and from that, as you suggested later in this email) > > + /* Short-circuit the easy case - kn_to is the root node. */ > > + if ((kn_from == kn_to) || (!kn_from && !kn_to->parent)) { > > + *p = '/'; > > + *(p + 1) = '\0'; > > Hmm... so if kn_from == kn_to, the output is "/"? Yes, that's what seems to make the most sense for cgroup namespaces. I could see a case for '.' being used instead in general, but for cgroup namespaces I think we'd have to convert those back to '/'. Otherwise we'll fail in being able to run legacy software, which would get confused. -serge -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists