lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 27 Nov 2015 11:05:10 +0900 From: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com> To: Minchan Kim <minchan@...nel.org> Cc: Andrew Morton <akpm@...ux-foundation.org>, Kyeongdon Kim <kyeongdon.kim@....com>, linux-kernel@...r.kernel.org, Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>, Sergey Senozhatsky <sergey.senozhatsky@...il.com> Subject: Re: [PATCH v2 3/3] zram: pass gfp from zcomp frontend to backend Hello, Minchan Kim wrote: [..] > +static struct zcomp_strm *zcomp_strm_alloc(struct zcomp *comp, gfp_t flags) > { > + zstrm = zcomp_strm_alloc(comp, GFP_NOIO|__GFP_NORETRY| > + __GFP_NOWARN|__GFP_NOMEMALLOC); and it seems that after 3/3 (v2) we also lost GFP_ZERO for private allocation. kzalloc->kmalloc, and no explicit __GFP_ZERO for __vmalloc(). > - ret = kzalloc(LZ4_MEM_COMPRESS, GFP_NOIO|__GFP_NORETRY| > - __GFP_NOWARN|__GFP_NOMEMALLOC); > + ret = kmalloc(LZ4_MEM_COMPRESS, flags); ^^^ here > if (!ret) > - ret = __vmalloc(LZ4_MEM_COMPRESS, GFP_NOIO|__GFP_NORETRY| > - __GFP_NOWARN|__GFP_NOMEMALLOC| > - __GFP_ZERO, > - PAGE_KERNEL); > + ret = __vmalloc(LZ4_MEM_COMPRESS, flags, PAGE_KERNEL); ^^^ here > - ret = kzalloc(LZO1X_MEM_COMPRESS, GFP_NOIO|__GFP_NORETRY| > - __GFP_NOWARN|__GFP_NOMEMALLOC); > + > + ret = kmalloc(LZO1X_MEM_COMPRESS, flags); ^^^ ditto > if (!ret) > - ret = __vmalloc(LZO1X_MEM_COMPRESS, GFP_NOIO|__GFP_NORETRY| > - __GFP_NOWARN|__GFP_NOMEMALLOC| > - __GFP_ZERO, > - PAGE_KERNEL); > + ret = __vmalloc(LZO1X_MEM_COMPRESS, flags, PAGE_KERNEL); ^^^ ditto so lz*_create() should look like --- static void *lzo_create(gfp_t flags) { void *ret; ret = kzalloc(LZO1X_MEM_COMPRESS, flags); if (!ret) ret = __vmalloc(LZO1X_MEM_COMPRESS, flags | __GFP_ZERO | __GFP_HIGHMEM, PAGE_KERNEL); return ret; } --- I have a patchset with my nitpicks addressed and fix-ups for missing gfps. Do you mind me to send it out? -ss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists