lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Nov 2015 23:43:29 -0800 From: tip-bot for Namhyung Kim <tipbot@...or.com> To: linux-tip-commits@...r.kernel.org Cc: namhyung@...nel.org, fweisbec@...il.com, wangnan0@...wei.com, mingo@...nel.org, acme@...hat.com, kan.liang@...el.com, jolsa@...hat.com, a.p.zijlstra@...llo.nl, andi@...stfloor.org, tglx@...utronix.de, hpa@...or.com, dsahern@...il.com, linux-kernel@...r.kernel.org Subject: [tip:perf/core] perf top: Fix freeze on --call-graph flat/folded Commit-ID: 0356218a68551f051998f4fb5074a1eed7a346fe Gitweb: http://git.kernel.org/tip/0356218a68551f051998f4fb5074a1eed7a346fe Author: Namhyung Kim <namhyung@...nel.org> AuthorDate: Thu, 26 Nov 2015 16:08:18 +0900 Committer: Arnaldo Carvalho de Melo <acme@...hat.com> CommitDate: Thu, 26 Nov 2015 13:32:08 -0300 perf top: Fix freeze on --call-graph flat/folded The callchain rbtree is rebuilt periodically, so it needs to reinitialize the root everytime. Otherwise it can be stuck in the rbtree insertion with stale pointers. Signed-off-by: Namhyung Kim <namhyung@...nel.org> Cc: Andi Kleen <andi@...stfloor.org> Cc: David Ahern <dsahern@...il.com> Cc: Frederic Weisbecker <fweisbec@...il.com> Cc: Jiri Olsa <jolsa@...hat.com> Cc: Kan Liang <kan.liang@...el.com> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl> Cc: Wang Nan <wangnan0@...wei.com> Link: http://lkml.kernel.org/r/1448521700-32062-1-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com> --- tools/perf/util/callchain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c index fc3b1e0..564377d 100644 --- a/tools/perf/util/callchain.c +++ b/tools/perf/util/callchain.c @@ -290,6 +290,7 @@ static void sort_chain_flat(struct rb_root *rb_root, struct callchain_root *root, u64 min_hit, struct callchain_param *param __maybe_unused) { + *rb_root = RB_ROOT; __sort_chain_flat(rb_root, &root->node, min_hit); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists