linux-kernel - Re: [PATCH] iwlwifi: fix compare_const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0BA3FCBA62E2DC44AF3030971E174FB32E90156E@hasmsx107.ger.corp.intel.com>
Date:	Sat, 28 Nov 2015 18:46:09 +0000
From:	"Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>
To:	Julia Lawall <julia.lawall@...6.fr>,
	"Kalle Valo <kvalo@...rom.com> Kalle Valo" <kvalo@...rom.com>
CC:	"kbuild-all@...org" <kbuild-all@...org>,
	"Berg, Johannes" <johannes.berg@...el.com>,
	linuxwifi <linuxwifi@...el.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iwlwifi: fix compare_const_fl.cocci warnings

Hi Julia,

On 11/27/2015 06:11 PM, Julia Lawall wrote:
> Move constants to the right of binary operators.
>
> Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
> ---
>
> This looks a bit nicer around the other way, in my opinion.

Thanks, I picked it up. I agree with your taste although having
constants on the left side can avoid the typo = instead of == since they
can't be an l-value. Obviously we never do that and prefer to have the
constant on the right side. More readable for sure.
>
>  calib.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/net/wireless/intel/iwlwifi/dvm/calib.c
> +++ b/drivers/net/wireless/intel/iwlwifi/dvm/calib.c
> @@ -311,7 +311,7 @@ static int iwl_sens_energy_cck(struct iw
>  		/* If previous beacon had too many false alarms,
>  		 *   give it some extra margin by reducing sensitivity again
>  		 *   (but don't go below measured energy of desired Rx) */
> -		if (IWL_FA_TOO_MANY == data->nrg_prev_state) {
> +		if (data->nrg_prev_state == IWL_FA_TOO_MANY) {
>  			IWL_DEBUG_CALIB(priv, "... increasing margin\n");
>  			if (data->nrg_th_cck > (max_nrg_cck + NRG_MARGIN))
>  				data->nrg_th_cck -= NRG_MARGIN;
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/