linux-kernel - Re: [PATCH 2/2] um: Use race-free temporary file creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <565A326F.4050005@digikod.net>
Date:	Sun, 29 Nov 2015 00:02:07 +0100
From:	Mickaël Salaün <mic@...ikod.net>
To:	Richard Weinberger <richard@....at>, linux-kernel@...r.kernel.org
Cc:	Jeff Dike <jdike@...toit.com>,
	Tristan Schmelcher <tschmelcher@...gle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	user-mode-linux-devel@...ts.sourceforge.net,
	user-mode-linux-user@...ts.sourceforge.net,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH 2/2] um: Use race-free temporary file creation


>>>> +			errno != EOPNOTSUPP))
>>>> +		return fd;
>>>> +	errno = 0;
>>>
>>> Why are you resetting errno?
>>
>> It's to ignore/reset the error code from open, but it may not be needed because of the next call to malloc?
> 
> But then you'd have to reset errno after every syscall. :-)

OK, I will remove it then :)

 Mickaël


Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)