lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 28 Nov 2015 09:20:26 +0800
From:	"Wangnan (F)" <wangnan0@...wei.com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
CC:	Alexei Starovoitov <ast@...nel.org>,
	<linux-kernel@...r.kernel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>, Jiri Olsa <jolsa@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Brendan Gregg <brendan.d.gregg@...il.com>,
	<lizefan@...wei.com>, <pi3orama@....com>,
	He Kuang <hekuang@...wei.com>
Subject: Re: RFC Re: [PATCH v2 04/13] perf tools: Add API to config maps in
 bpf object



On 2015/11/28 9:10, Arnaldo Carvalho de Melo wrote:
> Em Fri, Nov 27, 2015 at 08:47:38AM +0000, Wang Nan escreveu:
>> bpf__config_obj() is introduced as a core API to config BPF object
>> after loading. One configuration option of maps is introduced. After
>> this patch BPF object can accept configuration like:
>>
>>   maps:my_map:value=1234
>>
>> (maps.my_map.value looks pretty. However, there's a small but hard
>> to fixed problem related to flex's greedy matching. Please see [1].
>> Choose ':' to avoid it in a simpler way.)
> Understood the issues, but I would like to hear from Ingo, Jiri,
> Namhyung, Brian and others here, since we're setting up syntax, and yes,
> using:
>    
>    maps.my_map.value[0,3...6]=1234;
>
> or even:
>
>    maps->my_map->value[0,3...6]=1234;
>
> Looks more natural than:
>
>    maps:my_map:value[0,3...6]=1234;

You don't mention maps::my_map::value. C++ use '::' this way, so I think
it is also a possible choice.

Or we can use another character for example '|' to replace '/' in case we
have a map starting with 'c' or 'o'. For example:

./mybpf.c|maps.channel.value=1234|

and in normal case still support '/':

./mybpf.c/maps.channel.value=1234/

like 'sed':

# sed 's/a/b/g'
a
b
# sed 's+/+|+g'
/
|

Thank you.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists