linux-kernel - Re: [PATCH 1/3] perf report: Show error message when processing sample fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151128014851.GA2191@danjae>
Date:	Sat, 28 Nov 2015 10:48:51 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Jiri Olsa <jolsa@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 1/3] perf report: Show error message when processing
 sample fails

Hi Arnaldo,

On Fri, Nov 27, 2015 at 04:57:21PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Nov 27, 2015 at 04:56:27PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Sat, Nov 28, 2015 at 02:32:37AM +0900, Namhyung Kim escreveu:
> > > Currently when perf fails to process samples for some reason, it doesn't
> > > show any message about the failure.  This is very inconvenient for users
> > > especially on TUI as screen is reset after the failure.
> > > 
> > > Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> 
> Ah, I added a :
> 
> Reported-by: Ingo Molnar <mingo@...nel.org>
> 
> As this was due to those messages from Ingo, right?

Right.


> 
> > > ---
> > >  tools/perf/builtin-report.c | 12 +++++++++---
> > >  1 file changed, 9 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> > > index 8a9c6908f54e..af5db885ea9c 100644
> > > --- a/tools/perf/builtin-report.c
> > > +++ b/tools/perf/builtin-report.c
> > > @@ -513,20 +513,26 @@ static int __cmd_report(struct report *rep)
> > >  	if (rep->cpu_list) {
> > >  		ret = perf_session__cpu_bitmap(session, rep->cpu_list,
> > >  					       rep->cpu_bitmap);
> > > -		if (ret)
> > > +		if (ret) {
> > > +			ui__error("failed to set cpu bitmap\n");
> > 
> > Why? See below.
> > 
> > >  			return ret;
> > > +		}
> > >  	}
> > >  
> > >  	if (rep->show_threads)
> > >  		perf_read_values_init(&rep->show_threads_values);
> > >  
> > >  	ret = report__setup_sample_type(rep);
> > > -	if (ret)
> > > +	if (ret) {
> > > +		/* report__setup_sample_type() already showed error message */
> > >  		return ret;
> > > +	}
> > >  
> > >  	ret = perf_session__process_events(session);
> > > -	if (ret)
> > > +	if (ret) {
> > > +		ui__error("failed to process sample\n");
> > >  		return ret;
> > > +	}
> > 
> > I'm applying this because it removes the potential flash, but would be
> > good to have the reason for this failure shown to the user.

Yes, but at least the last error/warning will be shown in the bottom.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/