| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20151128083801.GA16777@dhcp-129-10.nay.redhat.com>
Date: Sat, 28 Nov 2015 16:38:01 +0800
From: Minfei Huang <mnfhuang@...il.com>
To: device-mapper development <dm-devel@...hat.com>
Cc: Alasdair Kergon <agk@...hat.com>,
Mike Snitzer <snitzer@...hat.com>, Neil Brown <neilb@...e.com>,
linux-raid@...r.kernel.org, Geliang Tang <geliangtang@....com>,
linux-kernel@...r.kernel.org
Subject: Re: [dm-devel] [PATCH] dm-ioctl: fix 4-characters indentations
Hi.
IMHO, this sort of defect shouldn't be fixed like this. It should be
fixed with other bugs, if necessary.
Once this patch is applied, it will break up the 'git blame'.
Thanks
Minfei
On 11/25/15 at 08:45pm, Geliang Tang wrote:
> Change 4-characters indentations to 8-characters.
>
> Signed-off-by: Geliang Tang <geliangtang@....com>
> ---
> drivers/md/dm-ioctl.c | 58 +++++++++++++++++++++++++--------------------------
> 1 file changed, 29 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
> index 80a4395..39aae6b 100644
> --- a/drivers/md/dm-ioctl.c
> +++ b/drivers/md/dm-ioctl.c
> @@ -45,10 +45,10 @@ struct dm_table {
> };
>
> struct vers_iter {
> - size_t param_size;
> - struct dm_target_versions *vers, *old_vers;
> - char *end;
> - uint32_t flags;
> + size_t param_size;
> + struct dm_target_versions *vers, *old_vers;
> + char *end;
> + uint32_t flags;
> };
>
>
> @@ -557,36 +557,36 @@ static int list_devices(struct dm_ioctl *param, size_t param_size)
>
> static void list_version_get_needed(struct target_type *tt, void *needed_param)
> {
> - size_t *needed = needed_param;
> + size_t *needed = needed_param;
>
> - *needed += sizeof(struct dm_target_versions);
> - *needed += strlen(tt->name);
> - *needed += ALIGN_MASK;
> + *needed += sizeof(struct dm_target_versions);
> + *needed += strlen(tt->name);
> + *needed += ALIGN_MASK;
> }
>
> static void list_version_get_info(struct target_type *tt, void *param)
> {
> - struct vers_iter *info = param;
> -
> - /* Check space - it might have changed since the first iteration */
> - if ((char *)info->vers + sizeof(tt->version) + strlen(tt->name) + 1 >
> - info->end) {
> -
> - info->flags = DM_BUFFER_FULL_FLAG;
> - return;
> - }
> -
> - if (info->old_vers)
> - info->old_vers->next = (uint32_t) ((void *)info->vers -
> - (void *)info->old_vers);
> - info->vers->version[0] = tt->version[0];
> - info->vers->version[1] = tt->version[1];
> - info->vers->version[2] = tt->version[2];
> - info->vers->next = 0;
> - strcpy(info->vers->name, tt->name);
> -
> - info->old_vers = info->vers;
> - info->vers = align_ptr(((void *) ++info->vers) + strlen(tt->name) + 1);
> + struct vers_iter *info = param;
> +
> + /* Check space - it might have changed since the first iteration */
> + if ((char *)info->vers + sizeof(tt->version) + strlen(tt->name) + 1 >
> + info->end) {
> +
> + info->flags = DM_BUFFER_FULL_FLAG;
> + return;
> + }
> +
> + if (info->old_vers)
> + info->old_vers->next = (uint32_t) ((void *)info->vers -
> + (void *)info->old_vers);
> + info->vers->version[0] = tt->version[0];
> + info->vers->version[1] = tt->version[1];
> + info->vers->version[2] = tt->version[2];
> + info->vers->next = 0;
> + strcpy(info->vers->name, tt->name);
> +
> + info->old_vers = info->vers;
> + info->vers = align_ptr(((void *) ++info->vers) + strlen(tt->name) + 1);
> }
>
> static int list_versions(struct dm_ioctl *param, size_t param_size)
> --
> 2.5.0
>
>
> --
> dm-devel mailing list
> dm-devel@...hat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists