lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 28 Nov 2015 09:59:19 +0000 From: Bharat Kumar Gogada <bharat.kumar.gogada@...inx.com> To: Arnd Bergmann <arnd@...db.de>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> CC: "robh+dt@...nel.org" <robh+dt@...nel.org>, "pawel.moll@....com" <pawel.moll@....com>, "mark.rutland@....com" <mark.rutland@....com>, "ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>, "galak@...eaurora.org" <galak@...eaurora.org>, Michal Simek <michals@...inx.com>, Soren Brinkmann <sorenb@...inx.com>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>, "tinamdar@....com" <tinamdar@....com>, "treding@...dia.com" <treding@...dia.com>, "rjui@...adcom.com" <rjui@...adcom.com>, "Minghuan.Lian@...escale.com" <Minghuan.Lian@...escale.com>, "m-karicheri2@...com" <m-karicheri2@...com>, "hauke@...ke-m.de" <hauke@...ke-m.de>, "marc.zyngier@....com" <marc.zyngier@....com>, "dhdang@....com" <dhdang@....com>, "sbranden@...adcom.com" <sbranden@...adcom.com>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Ravikiran Gummaluri <rgummal@...inx.com> Subject: RE: [PATCH v10] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL PCIe Host Controller > Subject: Re: [PATCH v10] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL > PCIe Host Controller > > On Friday 27 November 2015 20:32:03 Bharat Kumar Gogada wrote: > > + do { > > + err = nwl_pcie_link_up(pcie, PHY_RDY_LINKUP); > > + if (err != 1) { > > + check_link_up++; > > + if (check_link_up > LINKUP_ITER_CHECK) > > + return -ENODEV; > > + mdelay(1000); > > + } > > + } while (!err); > > mdelay(1000) is not something anyone should do. Why can't you call a > sleeping function here? > Agreed will use sleep function, will address it in next patch. Regards, Bharat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists