linux-kernel - Re: [PATCH] staging: skein: Adds test vectors & cleans up maros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20151129181245.GA27950@kroah.com>
Date:	Sun, 29 Nov 2015 10:12:45 -0800
From:	Gregkh <gregkh@...uxfoundation.org>
To:	jpage@...anota.de
Cc:	linux-kernel@...r.kernel.org, Jason <jason@...edaemon.net>
Subject: Re: [PATCH] staging: skein: Adds test vectors & cleans up maros

On Sun, Nov 29, 2015 at 12:51:30PM +0000, jpage@...anota.de wrote:
> The patch for cleaning up the Skein hash implementation  is included below.
> 
> The test & pass vectors for the hash function have been included, but not
> checked as the competition is still ongoing,as the final specification is
> unknown at this time.
> 
> The files are verbatim lifted from the author's website (https://
> www.schneier.com/code/skein_NIST_CD_102610.zip).
> The changes provide by me are moving all macros in the .c files to their
> repective .h files. As this was strictly a cosmetic change, I have not tested
> it with a rebuild.
> 
> This patch helps move the Skein driver along towards completion.
> 
> A signed version of this patch is included in the attachments.
> Also, please sign my attached GPG Key, if possible.
> Thank you.
> Signed-off-by: Sanidhya Solanki <jpage@...anota.de>
> 

Lots of this should be below in the changelog itself, the patch should
be "self-contained" and not need to be hand-edited in order to be
applied.

> 
> commit 6d50eca21b913f47899d9b91413968b8bccb6e31
> Author: Sanidhya Solanki <jpage@...anota.de>
> Date:   Fri Nov 27 01:54:23 2015 -0500

Why is this all here?  Please use git send-email to send a patch if your
email client can't just send them directly.

> 
>     - Added Test files.
>     - Moved macros to appropriate Header Files.
>     - Cleaned up TODO & added contact information.
>     - Passing Test Vectors remains.
>     - Adding module support remains.

That's a lot of different things all at once, please break this up into
a patch series, each one doing only one thing.

>    
>      Changes to be committed:
>         modified:   drivers/staging/skein/TODO
>         modified:   drivers/staging/skein/skein_block.c
>         copied:     drivers/staging/skein/skein_block.c -> drivers/staging/
> skein/skein_block.h
>         new file:   drivers/staging/skein/skein_test.c
>         new file:   drivers/staging/skein/skein_test.h

What is all of these lines for?

And you don't have a signed-off-by in the patch body itself.  My scripts
warned you about all of the above last time, why didn't you pay
attention to them?

And finally, please use scripts/get_maintainer.pl to determine the
correct people and mailing lists to send a patch to.

hope this helps,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/