linux-kernel - Re: [radeon r100] when ring test fails, provide users with option to test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151129222235.GA25692@amd>
Date:	Sun, 29 Nov 2015 23:22:35 +0100
From:	Pavel Machek <pavel@....cz>
To:	Christian König <christian.koenig@....com>
Cc:	Trivial patch monkey <trivial@...nel.org>,
	alexander.deucher@....com, airlied@...ux.ie,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [radeon r100] when ring test fails, provide users with option to
 test

On Sun 2015-11-29 20:48:53, Christian König wrote:
> On 28.11.2015 21:58, Pavel Machek wrote:
> >Ring test failure is often caused by too high agpmode. Tell the user
> >what to try.
> >
> >Signed-off-by: Pavel Machek <pavel@....cz>
> 
> NAK, the ring test can fail for any number of reasons and the agpmode is
> actually rather unlikely to be the cause.

Well, when I asked on the list "why this is happened" I got "umm,
noone knows" response that was not exactly helpful. And then someone
told me about agpmode.

If you know about the reasons it can fail, could you list them near
the DRM_ERROR, at least as a comment?

Thanks,
									Pavel

> Regards,
> Christian.
> 
> >
> >diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c
> >index 238b13f..32b1917 100644
> >--- a/drivers/gpu/drm/radeon/r100.c
> >+++ b/drivers/gpu/drm/radeon/r100.c
> >@@ -3665,7 +3665,7 @@ int r100_ring_test(struct radeon_device *rdev, struct radeon_ring *ring)
> >  	if (i < rdev->usec_timeout) {
> >  		DRM_INFO("ring test succeeded in %d usecs\n", i);
> >  	} else {
> >-		DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X)\n",
> >+		DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X), try radeon.agpmode=1?\n",
> >  			  scratch, tmp);
> >  		r = -EINVAL;
> >  	}
> >

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/