linux-kernel - Re: [PATCH] spi: dw-mid: constify dw_spi_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfkOMnBWWCZEowB0f_VSTMfOk_snQCm-J=DMv4x_4YUeg@mail.gmail.com>
Date:	Sun, 29 Nov 2015 02:56:44 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	Mark Brown <broonie@...nel.org>, kernel-janitors@...r.kernel.org,
	linux-spi <linux-spi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi: dw-mid: constify dw_spi_dma_ops structure

On Sat, Nov 28, 2015 at 4:09 PM, Julia Lawall <Julia.Lawall@...6.fr> wrote:
> The dw_spi_dma_ops structure is never modified, so declare it as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
>

Acked-by: Andy Shevchenko <andy.shevchenko@...il.com>

> ---
>  drivers/spi/spi-dw-mid.c |    2 +-
>  drivers/spi/spi-dw.h     |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-dw-mid.c b/drivers/spi/spi-dw-mid.c
> index bb1052e..9185f6c 100644
> --- a/drivers/spi/spi-dw-mid.c
> +++ b/drivers/spi/spi-dw-mid.c
> @@ -283,7 +283,7 @@ static void mid_spi_dma_stop(struct dw_spi *dws)
>         }
>  }
>
> -static struct dw_spi_dma_ops mid_dma_ops = {
> +static const struct dw_spi_dma_ops mid_dma_ops = {
>         .dma_init       = mid_spi_dma_init,
>         .dma_exit       = mid_spi_dma_exit,
>         .dma_setup      = mid_spi_dma_setup,
> diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h
> index 35589a2..61bc3cb 100644
> --- a/drivers/spi/spi-dw.h
> +++ b/drivers/spi/spi-dw.h
> @@ -130,7 +130,7 @@ struct dw_spi {
>         struct dma_chan         *rxchan;
>         unsigned long           dma_chan_busy;
>         dma_addr_t              dma_addr; /* phy address of the Data register */
> -       struct dw_spi_dma_ops   *dma_ops;
> +       const struct dw_spi_dma_ops *dma_ops;
>         void                    *dma_tx;
>         void                    *dma_rx;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-spi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/