linux-kernel - Re: [PATCH RESEND 1/2] vgacon: dummy implementation for vgacon_text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151129124903.GB17050@phenom.ffwll.local>
Date:	Sun, 29 Nov 2015 13:49:03 +0100
From:	Daniel Vetter <daniel@...ll.ch>
To:	Emil Velikov <emil.l.velikov@...il.com>
Cc:	Daniel Vetter <daniel.vetter@...ll.ch>,
	Intel Graphics Development <intel-gfx@...ts.freedesktop.org>,
	LKML <linux-kernel@...r.kernel.org>,
	DRI Development <dri-devel@...ts.freedesktop.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH RESEND 1/2] vgacon: dummy implementation for
 vgacon_text_force

On Fri, Nov 27, 2015 at 03:29:52PM +0000, Emil Velikov wrote:
> On 27 November 2015 at 15:10, Daniel Vetter <daniel.vetter@...ll.ch> wrote:
> > This allows us to ditch a ton of ugly #ifdefs from a bunch of drm modeset
> > drivers.
> >
> > v2: Make the dummy function actually return a sane value, spotted by
> > Ville.
> >
> > Cc: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> > Cc: Andrew Morton <akpm@...ux-foundation.org>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Signed-off-by: Daniel Vetter <daniel.vetter@...ll.ch>
> > ---
> >  drivers/gpu/drm/ast/ast_drv.c         | 2 --
> >  drivers/gpu/drm/cirrus/cirrus_drv.c   | 2 --
> >  drivers/gpu/drm/i915/i915_drv.c       | 2 --
> >  drivers/gpu/drm/mgag200/mgag200_drv.c | 2 --
> >  drivers/gpu/drm/nouveau/nouveau_drm.c | 2 --
> >  drivers/gpu/drm/qxl/qxl_drv.c         | 2 --
> >  drivers/gpu/drm/radeon/radeon_drv.c   | 2 --
> >  include/linux/console.h               | 2 ++
> 
> The new drivers seems to be missing the conversion. Namely amdgpu and
> virtio_gpu.

Just shows how old this patch is ;-) And it's not going to cause a
problem since this patch simply makes the #ifdef redundant.

Greg, do you prefer a respin or a fixup patch?

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/