lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 29 Nov 2015 14:15:09 +0100 From: Alban Bedel <albeu@...e.fr> To: linux-kernel@...r.kernel.org Cc: Alban Bedel <albeu@...e.fr>, Russell King <linux@....linux.org.uk>, linux-arm-kernel@...ts.infradead.org Subject: [PATCH] clkdev: Fix of_clk_get_by_name() for consistent return values When of_clk_get_by_name() is called without name it returns -ENOENT when the 'clocks' property doesn't exists or is an empty entry. However when a name is given and the 'clock-names' property doesn't exists or doesn't contains the requested name it returns -EINVAL. To get a consistent return value with both code paths we must return -ENOENT when of_property_match_string() fails. Signed-off-by: Alban Bedel <albeu@...e.fr> --- drivers/clk/clkdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c index 779b6ff..99a8803 100644 --- a/drivers/clk/clkdev.c +++ b/drivers/clk/clkdev.c @@ -72,7 +72,10 @@ static struct clk *__of_clk_get_by_name(struct device_node *np, */ if (name) index = of_property_match_string(np, "clock-names", name); - clk = __of_clk_get(np, index, dev_id, name); + if (index >= 0) + clk = __of_clk_get(np, index, dev_id, name); + else + clk = ERR_PTR(-ENOENT); if (!IS_ERR(clk)) { break; } else if (name && index >= 0) { -- 2.0.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists