linux-kernel - Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Nov 2015 11:58:40 +0530
From:	Saurabh Sengar <saurabh.truth@...il.com>
To:	mathias.nyman@...el.com, Greg KH <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:	Saurabh Sengar <saurabh.truth@...il.com>
Subject: Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

pinging in case this patch is lost.


On 6 November 2015 at 17:46, Saurabh Sengar <saurabh.truth@...il.com> wrote:
> added iounmap inorder to free memory mapped to base before returning
>
> Signed-off-by: Saurabh Sengar <saurabh.truth@...il.com>
> ---
>  drivers/usb/host/pci-quirks.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index f940056..332f687 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -990,7 +990,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
>                         /* We're reading garbage from the controller */
>                         dev_warn(&pdev->dev,
>                                  "xHCI controller failing to respond");
> -                       return;
> +                       goto iounmap;
>                 }
>
>                 if (!ext_cap_offset)
> @@ -1061,7 +1061,7 @@ hc_init:
>                          "xHCI HW did not halt within %d usec status = 0x%x\n",
>                          XHCI_MAX_HALT_USEC, val);
>         }
> -
> +iounmap:
>         iounmap(base);
>  }
>
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/