linux-kernel - Re: [PATCH] tools/thermal: tmon: cleanup function init_thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 30 Nov 2015 16:27:37 +0530
From:	Anup Limbu <anuplimbu14@...il.com>
To:	Anand Moon <linux.amoon@...il.com>
Cc:	Zhang Rui <rui.zhang@...el.com>,
	Jacob Pan <jacob.jun.pan@...ux.intel.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Brian Norris <computersforpeace@...il.com>, acme@...hat.com,
	olaf@...fle.de, Arjun Sreedharan <arjun024@...il.com>,
	linux-pm@...r.kernel.org, Linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/thermal: tmon: cleanup function init_thermal_controller

 +Linux-kernel@...r.kernel.org +linux-pm@...r.kernel.org

On Sun, Nov 29, 2015 at 9:08 PM, Anand Moon <linux.amoon@...il.com> wrote:
> Hi Anup,
>
> On 27 November 2015 at 17:26, Anup Limbu <anuplimbu14@...il.com> wrote:
>> Replacing return type of function as void from int and removing
>> unused variable ret.
>>
>> Signed-off-by: Anup Limbu <anuplimbu14@...il.com>
>> ---
>>  tools/thermal/tmon/pid.c  | 5 +----
>>  tools/thermal/tmon/tmon.h | 2 +-
>>  2 files changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/tools/thermal/tmon/pid.c b/tools/thermal/tmon/pid.c
>> index fd7e9e9..c034bf3 100644
>> --- a/tools/thermal/tmon/pid.c
>> +++ b/tools/thermal/tmon/pid.c
>> @@ -63,10 +63,8 @@ static double xk_1, xk_2; /* input temperature x[k-#] */
>>   *
>>   * add a flag for tuning PID
>>   */
>> -int init_thermal_controller(void)
>> +void init_thermal_controller(void)
>>  {
>> -       int ret = 0;
>> -
>>         /* init pid params */
>>         p_param.ts = ticktime;
>>         /* TODO: get it from TUI tuning tab */
>> @@ -76,7 +74,6 @@ int init_thermal_controller(void)
>>
>>         p_param.t_target = target_temp_user;
>>
>> -       return ret;
>>  }
>>
>>  void controller_reset(void)
>> diff --git a/tools/thermal/tmon/tmon.h b/tools/thermal/tmon/tmon.h
>> index 9e3c49c..016569d 100644
>> --- a/tools/thermal/tmon/tmon.h
>> +++ b/tools/thermal/tmon/tmon.h
>> @@ -139,7 +139,7 @@ struct pid_params {
>>         double y_k;
>>  };
>>
>> -extern int init_thermal_controller(void);
>> +extern void init_thermal_controller(void);
>>  extern void controller_handler(const double xk, double *yk);
>>
>>  extern struct tmon_platform_data ptdata;
>> --
>> 1.9.1
>>
>
> BTW, next time when sending a thermal related change, please cc
> linux-pm@...r.kernel.org, or else the change may got because we usually
> rely on https://patchwork.kernel.org/project/linux-pm/list/ to review
> and scrub the patches. :)
>
> ---Zhang Rui <rui.zhang@...el.com>
>
> Tested-by: Anand Moon <linux.amoon@...il.com>
>
> -Anand Moon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/