lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Nov 2015 14:21:29 +0100 From: Michal Hocko <mhocko@...nel.org> To: Pavel Machek <pavel@....cz> Cc: davem@...emloft.net, Andrew Morton <akpm@...l.org>, kernel list <linux-kernel@...r.kernel.org>, jcliburn@...il.com, chris.snook@...il.com, netdev@...r.kernel.org, "Rafael J. Wysocki" <rjw@...ysocki.net>, linux-mm@...ck.org, nic-devel@...lcomm.com, ronangeles@...il.com, ebiederm@...ssion.com Subject: Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation On Sat 28-11-15 15:51:13, Pavel Machek wrote: > > atl1c driver is doing order-4 allocation with GFP_ATOMIC > priority. That often breaks networking after resume. Switch to > GFP_KERNEL. Still not ideal, but should be significantly better. It is not clear why GFP_KERNEL can replace GFP_ATOMIC safely neither from the changelog nor from the patch context. It is correct here because atl1c_setup_ring_resources is a sleepable context (otherwise tpd_ring->buffer_info = kzalloc(size, GFP_KERNEL) would be incorrect already) but a short note wouldn't kill us, would it? > Signed-off-by: Pavel Machek <pavel@....cz> Anyway Reviewed-by: Michal Hocko <mhocko@...e.com> > > diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > index 2795d6d..afb71e0 100644 > --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > @@ -1016,10 +1016,10 @@ static int atl1c_setup_ring_resources(struct atl1c_adapter *adapter) > sizeof(struct atl1c_recv_ret_status) * rx_desc_count + > 8 * 4; > > - ring_header->desc = pci_alloc_consistent(pdev, ring_header->size, > - &ring_header->dma); > + ring_header->desc = dma_alloc_coherent(&pdev->dev, ring_header->size, > + &ring_header->dma, GFP_KERNEL); > if (unlikely(!ring_header->desc)) { > - dev_err(&pdev->dev, "pci_alloc_consistend failed\n"); > + dev_err(&pdev->dev, "could not get memmory for DMA buffer\n"); > goto err_nomem; > } > memset(ring_header->desc, 0, ring_header->size); > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists